Merged
Conversation
We don't need to call ``updateRelativeTimeViews`` when the activity is paused, because the user likely won't notice it. Despite that onResume already calls ``updateRelativeTimeViews`` so there is no need to do that twice.
Stypox
approved these changes
Jul 19, 2021
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Code looks good. I tested with a video in the feed published 19 minutes ago and after waiting 1 minute and switching to another app and then back to newpipe it became 20 minutes. Thanks :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This issue fixes 2 build warnings/deprecations:
The code on these parts was relatively old (>2 years).
Description of the fixes:
FeedFragment: Removed updateRelativeTimeViews when the activity is pausedWe don't need to call
updateRelativeTimeViewswhen the activity is paused, because the user likely won't notice it (because it is paused).Despite that
onResumealready callsupdateRelativeTimeViewsso there is no need to do that twice.SubscriptionFragment: Simplified code and adjusted the style so that it's similar to FeedFragmentThe title there got set twice (no idea why). Simply copied use the same code (2 lines) from FeedFragment
Before/After Screenshots/Screen Record
not applicable
Fixes the following issue(s)
not applicable
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence